Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Doc] add squeeze to Array change shape #15549

Merged
merged 6 commits into from
Jul 24, 2019

Conversation

ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented Jul 16, 2019

Description

Since squeeze performs same function as mentioned in the header - Array change shape
https://mxnet.incubator.apache.org/api/python/ndarray/ndarray.html#array-change-shape

squeeze definition
https://mxnet.incubator.apache.org/api/python/ndarray/ndarray.html#mxnet.ndarray.squeeze

Thus, it should be placed in the same class of operators.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • ndarray.md file

@ChaiBapchya ChaiBapchya requested a review from szha as a code owner July 16, 2019 01:27
@karan6181
Copy link
Contributor

@mxnet-label-bot add [Doc, pr-awaiting-review]

@marcoabreu marcoabreu added Doc pr-awaiting-review PR is waiting for code review labels Jul 16, 2019
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you : )

@ChaiBapchya
Copy link
Contributor Author

@aaronmarkham can you help review? Minor doc fix

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronmarkham aaronmarkham merged commit 81ae341 into apache:master Jul 24, 2019
@ChaiBapchya ChaiBapchya deleted the squeeze_doc_fix branch July 29, 2019 22:33
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
* add squeeze to Array change shape

* Trigger notification

* Trigger notification

* Trigger notification

* Trigger notification
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Doc pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants